feat!: configurable key to ID conversion#379
Open
erikwrede wants to merge 6 commits intographql-python:masterfrom
Open
feat!: configurable key to ID conversion#379erikwrede wants to merge 6 commits intographql-python:masterfrom
erikwrede wants to merge 6 commits intographql-python:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 94.74% 96.30% +1.55%
==========================================
Files 10 9 -1
Lines 1333 921 -412
==========================================
- Hits 1263 887 -376
+ Misses 70 34 -36 ☔ View full report in Codecov by Sentry. |
jendrikjoe
approved these changes
Feb 1, 2023
Contributor
jendrikjoe
left a comment
jendrikjoe
left a comment
There was a problem hiding this comment.
Rest seems good. Maybe adding a test to ensure that actually querying an object returns as well the expected type (e.g. int not the converted id) might be helpful just for completeness 👍
sabard
reviewed
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #102 by giving users the choice to either convert all Key Columns to
graphene.IDor leave all key columns as is.